Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 7 sends ASCII control characters not handled by the TerminalDecoder #29606

Closed
dbaeumer opened this issue Jun 27, 2017 · 1 comment
Closed
Assignees
Labels
tasks Task system issues
Milestone

Comments

@dbaeumer
Copy link
Member

  • VSCode Version: insider
  • OS Version: Windows

Steps to Reproduce:

  • node 7.4.0
  • typescript installed locally
  • tasks.json
{
    "version": "2.0.0",

    // we want to run npm
    "command": "npm",

    "type": "shell",

    "presentation": {
        "reveal": "never"
    },
    "group": { "kind": "build", "isPrimary": true },

    // we run the custom script "compile" as defined in package.json
    "args": ["run", "compile", "--loglevel", "silent"],

    // The tsc compiler is started in watching mode
    "isBackground": true,

    // use the standard tsc in watch mode problem matcher to find compile problems in the output.
    "problemMatcher": "$tsc-watch"
}
  • TS file and tsconfig.json
  • run the task

Observe: the spinner never quits. The reason is that node 7.x sends an ASCII control sequence like 27]...BEL which is not handled by the terminal decoder.

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added tasks Task system issues insiders labels Jun 27, 2017
@dbaeumer dbaeumer added this to the June 2017 milestone Jun 27, 2017
@dbaeumer dbaeumer self-assigned this Jun 27, 2017
@dbaeumer
Copy link
Member Author

See also: #29840

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tasks Task system issues
Projects
None yet
Development

No branches or pull requests

1 participant