Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension widget keeps resorting #29779

Closed
Tracked by #131187 ...
jrieken opened this issue Jun 28, 2017 · 21 comments
Closed
Tracked by #131187 ...

Extension widget keeps resorting #29779

jrieken opened this issue Jun 28, 2017 · 21 comments
Assignees
Labels
extensions Issues concerning extensions marketplace Microsoft VS Code Marketplace issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach

Comments

@jrieken
Copy link
Member

jrieken commented Jun 28, 2017

See attach recording. The extension viewlet resort while I hover over items. That causes me to select the wrong extension

jun-28-2017 19-17-37

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Jun 28, 2017
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2017
@jrieken jrieken changed the title Extension widget keeps resorting [regression] extension widget keeps resorting Jun 28, 2017
@jrieken jrieken added the important Issue identified as high-priority label Jun 28, 2017
@egamma egamma added this to the June 2017 milestone Jun 29, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Jun 29, 2017

We don't control the sorting. The Marketplace does. It's hardly a regression.

@jrieken
Copy link
Member Author

jrieken commented Jun 29, 2017

In the May release thing clear when retyping and then stuff comes in one by one in the correct order

@sandy081
Copy link
Member

sandy081 commented Jun 29, 2017

To me it looks like new results are shown after typing after a delay which are sorted based on the new filter.

But will investigate, if there are any changes from our side that causing this.

@joaomoreno
Copy link
Member

Here's 1.11.2:

kapture 2017-06-29 at 10 00 53

@joaomoreno joaomoreno changed the title [regression] extension widget keeps resorting Extension widget keeps resorting Jun 29, 2017
@joaomoreno joaomoreno removed the important Issue identified as high-priority label Jun 29, 2017
@jrieken
Copy link
Member Author

jrieken commented Jun 29, 2017

You are not doing what I did (this is the old version)
jun-29-2017 10-00-24

@jrieken jrieken added the important Issue identified as high-priority label Jun 29, 2017
@joaomoreno
Copy link
Member

In the first video you typed g instead of clearing the input.

@joaomoreno joaomoreno removed their assignment Jun 29, 2017
@jrieken
Copy link
Member Author

jrieken commented Jun 29, 2017

true, not a regression. still major mess up. we argue everyone against dynamic updating UI, like in reference search or cmd+o, but here we are doing exactly this. Before re-querying we need to clear the crap

@joaomoreno
Copy link
Member

joaomoreno commented Jun 29, 2017

Major mess up that's been there since the beginning. So, hardly important.

@jrieken
Copy link
Member Author

jrieken commented Jun 29, 2017

Major mess up that's been there since the beginning. So, hardly important.

I like that logic.

@sandy081
Copy link
Member

Removing from June as per discussion in Stand Up

@sandy081 sandy081 modified the milestones: July 2017, June 2017 Jun 29, 2017
@sandy081 sandy081 modified the milestones: August 2017, July 2017 Jul 27, 2017
@sandy081 sandy081 modified the milestones: Backlog, August 2017 Aug 22, 2017
@sandy081 sandy081 removed the important Issue identified as high-priority label Nov 22, 2017
@sandy081 sandy081 added the debt Code quality issues label Sep 14, 2018
@sandy081
Copy link
Member

Not sure what we can do it here worst is to clear the results when a new search is triggered. Some users might like and some does not. This will at least not allow users to select wrong extension.

kapture 2018-09-14 at 17 01 06

@joaomoreno ??

@jrieken
Copy link
Member Author

jrieken commented Sep 17, 2018

Can't we ask the market place for a downloadable index? There are less than 10000 extensions: a summary with their searchable information (title, label, description) should be small enough to be downloadable and having that we can apply our sorting/filtering that we use throughout the product (and avoid this flashiness)

@joaomoreno
Copy link
Member

I believe the Marketplace wants to own the relevance sorting. We also don't want to maintain a relevance sorting ourselves. cc @viradhamMS @pkuma-msft for comments. It would be great if narrowing down a search by adding more characters to the query would minimize resorting.

@sandy081 sandy081 added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Sep 17, 2018
@sandy081
Copy link
Member

we can apply our sorting/filtering that we use throughout the product (and avoid this flashiness)

This will cause inconsistency with Market place website. Not sure if it is a good idea.

@jrieken
Copy link
Member Author

jrieken commented Sep 17, 2018

This will cause inconsistency with Market place website. Not sure if it is a good idea.

I think that's a brilliant idea because today the extensions viewlet is the only place in which the sorting is different from anything else in our tool. All the select-by-typing tricks that have made it into my muscle memory don't work in the extensions viewlet and I always leave it frustrated.

@viradhamMS
Copy link

@joaomoreno : You are right., the relevance algorithm in Marketplace takes care of downloads, ratings apart from the appropriate weightages given to display name, publisher name, tags, brief description. It wouldn't be a good idea to duplicate the algorithm in the clients. In the near future, we might move to Azure Search or Bing APIs to improve the performance and scalability of the search further. If Clients start duplicating the algorithm, it would be hard to play catch upon such technology moves for better results/performance.

@jrieken
Copy link
Member Author

jrieken commented Sep 18, 2018

the relevance algorithm in Marketplace takes care of downloads, ratings apart from the appropriate weightages given to display name, publisher name, tags, brief description.

But all these things don't change while a user types. Having them once and using them for a snappy filtering/sorting will be what we do everywhere else. This is like completions that we request once and then sort/filter using our rules (respecting the information extension gave us, e.g. sortText, filterText, range, etc)

@sandy081 sandy081 added the marketplace Microsoft VS Code Marketplace issues label Sep 18, 2018
@sandy081 sandy081 removed this from the Backlog milestone Sep 18, 2018
@pkuma-msft
Copy link

pkuma-msft commented Sep 18, 2018

But all these things don't change while a user types. Having them once and using them for a snappy filtering/sorting will be what we do everywhere else.

Not sure what you mean by this. For example searching for 'test' returns 178 results whereas searching for 'test mocha' returns 180 results. Are you suggesting we download the full catalog to the client and work off of it?

@jrieken
Copy link
Member Author

jrieken commented Sep 19, 2018

Are you suggesting we download the full catalog to the client and work off of it?

Yes

@codedChaos
Copy link

Just commenting to remind myself to research and elaborate in the morning but has anyone mentioned, or an issue been created around the inefficacy of using two sort filters in a search?

In my years of VS Code extension searches, I typically have tried to improve results by using two sorting metrics. My biggest example is usually something like this:
thing-i-want @sort:rating @sort:ratingcount
I do this because simply sorting by rating returns plenty of 5-star extensions with only one to five actual reviews, which means diddly-squat to me. I want ratings over a 4 with at least a couple dozen reviewers/raters. Is it just me on this?

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Dec 6, 2022
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions marketplace Microsoft VS Code Marketplace issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

9 participants