Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ignore files option combined with files to include set seems to be broken in 1.14 (works fine in 1.13.1) #30612

Closed
kompot opened this issue Jul 13, 2017 · 1 comment
Closed

Use ignore files option combined with files to include set seems to be broken in 1.14 (works fine in 1.13.1) #30612

kompot opened this issue Jul 13, 2017 · 1 comment
Assignees
@roblourens
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@kompot
Copy link

kompot commented Jul 13, 2017

  • VSCode Version:
    1.14.0 final and
    Code - Insiders 1.15.0-insider (74f5073, 2017-07-12T05:07:15.561Z)
  • OS Version: Darwin x64 16.6.0

Steps to Reproduce:

  1. Open project with some .gitignored files
  2. Search with Use ignore files option enabled and files to include set to some subfolder (like ./back that belongs to the project root).
  3. 1.13.1 does not include ignored files within ./back, 1.14.0 final and 1.15.0-insiders do include
  4. If files to include is empty - everything work as expected.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the search Search widget and operation issues label Jul 13, 2017
@roblourens
Copy link
Member

This will be fixed as part of #27226 (comment)

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 13, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kompot @roblourens