Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM and extensions viewlet - uneven margins #30648

Closed
roblourens opened this issue Jul 13, 2017 · 2 comments
Closed

SCM and extensions viewlet - uneven margins #30648

roblourens opened this issue Jul 13, 2017 · 2 comments
Assignees
Labels
ux User experience issues

Comments

@roblourens
Copy link
Member

From #30250 (comment)

The input boxes at the top of these two viewlets have much larger margins on the left than the right. The extensions box kind of lines up with the extension item text below, which maybe is the goal. In the SCM viewlet, it doesn't seem to line up with anything. Never noticed it before, but I think they would look better centered.

gutter

@joaomoreno
Copy link
Member

I am a strong believer that type should have the highest alignment priority. Aligning the type inside the input box with the title in those two viewlets was definitely a purposeful change.

image

Somehow that alignment fails in the extension viewlet, when icons aren't visible. Seems like a bug.

@joaomoreno
Copy link
Member

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.

Thanks for your understanding. Happy coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues
Projects
None yet
Development

No branches or pull requests

2 participants