Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external diff algorithms in internal diff editor #30694

Closed
myfairsyer opened this issue Jul 14, 2017 · 2 comments
Closed

Support external diff algorithms in internal diff editor #30694

myfairsyer opened this issue Jul 14, 2017 · 2 comments
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@myfairsyer
Copy link

myfairsyer commented Jul 14, 2017

While #15661 asks for the ability to launch external diff programs in their own user interface I'd rather like VSCode to parse the patch formatted output of another (probably mainly cli?) diff tool and show the results in the regular built-in diff editor

In #15661 @joaomoreno suggested writing an extension but I suppose this here would not be possible with an extension, right?

Just like in #15661 one of the use cases I have in mind is using git's built in diff algorithms. For that use case I'd also love to see an option that respects what is being set in git's settings (although I guess this should be possible to be managed in an extension when the base functionality of using external diff algorithms in the internal diff editor is implemented, right?)

@vscodebot vscodebot bot added the git GIT issues label Jul 14, 2017
@joaomoreno joaomoreno assigned alexdima and unassigned joaomoreno Jul 17, 2017
@alexdima alexdima added feature-request Request for new features or functionality diff-editor Diff editor issues and removed git GIT issues labels Aug 10, 2017
@alexdima alexdima added this to the Backlog milestone Aug 10, 2017
@alexdima alexdima removed their assignment Aug 10, 2017
@alexdima
Copy link
Member

Since last year, we have enhanced our diff algorithm with git's whitespace heuristic that brings diff hunks together (reduces their count in many cases) and have added another heuristic for comparisons when ignore trim whitespace is off. I think we should focus on doing additional improvements in our diff algorithm rather than integrating an external diff tool that at the end of the day also contains a diff algorithm...

@alexdima alexdima added the *out-of-scope Posted issue is not in scope of VS Code label Sep 22, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 22, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants