Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use electron's remote in event handlers #3072

Closed
alexdima opened this issue Feb 17, 2016 · 4 comments
Closed

Do not use electron's remote in event handlers #3072

alexdima opened this issue Feb 17, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

See #2829

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Feb 17, 2016
@bpasero bpasero added this to the March 2016 milestone Feb 29, 2016
@egamma egamma mentioned this issue Feb 29, 2016
82 tasks
@bpasero
Copy link
Member

bpasero commented Mar 2, 2016

I have pushed changes to greatly reduce use of remote in the renderer. One of the few things I left out for now is the context menu which I extracted into #3638. I pushed a change though to use a timeout of 0 to make sure that we are not using remote from event handlers.

Areas to verify:

  • most importantly: the bug with pressing "Tab" getting wrong is not happening anymore
  • toggle dev tools
  • reload window
  • mac: shows "represented" file name in window title area when opening files and removes it when closing last editor
  • mac: window shows as "dirty" when having dirty files by drawing a black dot in the close button of the window and removes this dot when no more dirty files are present
  • save dialog still works and shows up for dirty files when closing workbench or closing the working file
  • going full screen, leaving full screen
  • toggling menu bar visibility
  • context menu still works (in trees, editor, dropdown "...")

@bpasero bpasero closed this as completed in 7975b1b Mar 2, 2016
@bpasero bpasero assigned alexdima and unassigned bpasero Mar 2, 2016
@alexdima
Copy link
Member Author

alexdima commented Mar 3, 2016

Nice!!

@alexdima
Copy link
Member Author

I didn't start reviewing the commit, I trust you do the right thing. Thank you!

@alexdima alexdima added the verified Verification succeeded label Mar 21, 2016
@bpasero
Copy link
Member

bpasero commented Mar 21, 2016

I feel honoured ;)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants