Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate folders in .code-workspace #31084

Closed
chrisdias opened this issue Jul 19, 2017 · 2 comments
Closed

Duplicate folders in .code-workspace #31084

chrisdias opened this issue Jul 19, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@chrisdias
Copy link
Member

testing #30722

Insiders 1.15.0
9a308d1

Loading of folders stops if a folder is repeated in the .code-workspace file. admittedly a poorly formed file :)

loading foo.code-workspace

{
	"id": "1500494428473",
	"folders": [
		"file:///Users/chris/src/vscode-mongodb",
		"file:///Users/chris/src/vscode-docker",
		"file:///Users/chris/src/vscode-docker",
		"file:///Users/chris/src/vscode-azurelogin",
		"file:///Users/chris/src/vscode-azureappservice",
		"file:///Users/chris/src/vscode-extension-samples"
	]
}

results in only the vscode-mongodb and vscode-docker folders being loaded.

image

i would expect it to keep on loading the rest of the folders in this case since the vscode-docker folder is valid, you just don't have to load it 2x.

@bpasero
Copy link
Member

bpasero commented Jul 20, 2017

@sandy081 this should be de-duplicated on the level of the workspace service imho within the workbench.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-multiroot Multi-root (multiple folders) issues labels Jul 20, 2017
@sandy081
Copy link
Member

Hmm strange.. will look into it.

@sandy081 sandy081 added this to the July 2017 milestone Jul 20, 2017
@roblourens roblourens added the verified Verification succeeded label Aug 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

4 participants