Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt+F, S doesn't always save #31484

Closed
natewaddoups opened this issue Jul 26, 2017 · 4 comments
Closed

Alt+F, S doesn't always save #31484

natewaddoups opened this issue Jul 26, 2017 · 4 comments
Assignees
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@natewaddoups
Copy link

  • VSCode Version: Code 1.13.1 (379d2ef, 2017-06-14T18:21:47.485Z)
  • OS Version: Windows_NT ia32 10.0.15063
  • Extensions:
Extension Author Version
bracket-pair-colorizer CoenraadS 0.10.7
sort-typescript-imports miclo 1.3.0
csharp ms-vscode 1.11.0
debugger-for-chrome msjsdiag 3.1.6

Steps to Reproduce:

  1. Try to save your changes with hotkeys: press "Alt+F" followed by "S".

Expected results: Your changes are saved and you can continue working.

Actual results: The File menu is still showing, changes are not saved, and subsequent keystrokes will be interpreted as File menu hotkeys.

Workaround #1: Press "S" again.
Workaround #2: Pause briefly after "Alt+F". The "S" will work the first time.

There seems to be a race condition where the "S" keystroke gets swallowed before the File menu is displayed.

Data loss has led me to develop an Alt+F,S twitch over the years - I do that key combination every few minutes, without thinking about it, in all applications, and have done so for more than a decade. I've never run into this obstacle in other applications, and it is kind of aggravating to trip over this every time I use VS Code.

@rebornix rebornix self-assigned this Jul 27, 2017
@rebornix rebornix added the editor-core Editor basic functionality label Jul 27, 2017
@JackTrapper
Copy link

It took me about twenty minutes one day to figure out why the web-site was not honoring my updated code file. I know i saved it. Refresh the web-page - old behavior.

  • Save again - Alt+F S
  • copy to the server

Still not working. I view the file on the server, and it's the old version. Huh, i guess i copied the file to the wrong place.

  • copy to the server again.

Still the wrong version. Open the server version on the server; its the old version. What the hell. Maybe i forgot to save it

  • Alt+F S
  • copy to server

Server still isn't working.

"I know i saved it. And i swear i copied it to the right location

Use Beyond Compare to diff my location version, and the version on the server. They're identical.

How can Beyond Compare say that the two versions match, when i know the version on the server is wrong?!

Look at the comparison inside Beyond Compare; it says that local copy is wrong. That's not possible, i know i saved it!

  • Save again Alt+F S

See, no changes picked up by Beyond Compare; the file is current. To prove it i'll make a minor change in the text file, and save it. The file on the disk doesn't change.

Is it possible that Code isn't saving?

  • Click File menu
  • Click Save

changes picked up.

What? Does Alt+F S not work?

  • Alt+F S
  • Alt+F S
  • Alt+F S
  • Alt+F S

Ohhh, i see.

They decided to re-implement menus from scratch, rather than using the tried and true Windows menu control used by every other application on the planet.

Oh well.

@rebornix
Copy link
Member

rebornix commented Aug 15, 2017

cc @bpasero first to see if he has some ideas about what's happening there, it seems related to #32218

@rebornix rebornix removed their assignment Aug 15, 2017
@rebornix rebornix removed the editor-core Editor basic functionality label Aug 15, 2017
@bpasero
Copy link
Member

bpasero commented Aug 15, 2017

Duplicate of #20696 ?

@bpasero bpasero added menu upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 15, 2017
@bpasero bpasero added this to the Backlog milestone Aug 15, 2017
@bpasero bpasero added the electron Issues and items related to Electron label Aug 15, 2017
@bpasero
Copy link
Member

bpasero commented Nov 14, 2017

#5556

@bpasero bpasero closed this as completed Nov 14, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants