Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel actions are cropped when window is narrow #31503

Closed
sandy081 opened this issue Jul 27, 2017 · 12 comments
Closed

Panel actions are cropped when window is narrow #31503

sandy081 opened this issue Jul 27, 2017 · 12 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan ux User experience issues
Milestone

Comments

@sandy081
Copy link
Member

image

@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2017

Do you mean the actions on the panel?

@Tyriar Tyriar added ux User experience issues workbench labels Jul 27, 2017
@sandy081
Copy link
Member Author

Yes

@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2017

@sandy081 Can not repro.
How did you get in that state?
Was the editor croped as well, or only the terminal? Were the other panels cropped as well?

@isidorn isidorn added the info-needed Issue requires more information from poster label Jul 28, 2017
@Tyriar
Copy link
Member

Tyriar commented Jul 28, 2017

@isidorn the actions at the top of the panel (new terminal, kill terminal). Just make the window narrow.

@Tyriar Tyriar changed the title Terminal actions are cropped Panel actions are cropped when window is narrow Jul 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2017

@Tyriar thanks for clarifying.
What would you expect @sandy081 to happen in this case.

I believe the elements are getting hidden in the correct order.

shrink

@Tyriar
Copy link
Member

Tyriar commented Jul 28, 2017

We need some way of accessing the elements in the overflow, the tasks panel is making this a bigger problem than it was before.

@isidorn
Copy link
Contributor

isidorn commented Jul 31, 2017

@Tyriar can you please elaborate on that?

@Tyriar
Copy link
Member

Tyriar commented Jul 31, 2017

We should strive to be usable at very narrow widths, a triple dot menu is probably the solution, just like to the right of the tab well.

Trying to use 2 instances side by side isn't too bad except for with the panel:

image

The Tasks button exacerbated the problem as it hides actions when the window is wider.

@isidorn
Copy link
Contributor

isidorn commented Aug 2, 2017

I like the triple dot idea, I can look into it in the next couple of milestones

@isidorn isidorn added this to the On Deck milestone Aug 2, 2017
@isidorn isidorn added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Aug 2, 2017
@bpasero
Copy link
Member

bpasero commented Aug 16, 2017

@isidorn @Tyriar Ideally the panel overflow behaviour is the same as the activity bar when the window gets small. As you can see below, the UI is very similar, there are entries for each viewlet and there are actions (the gear icon):

image

I suggest to:

  • keep the panel actions visible at all times
  • start to show a "..." for the actual panels similar to how we do it for viewlets
  • when you click "..." you can pick another panel

@equinusocio
Copy link

equinusocio commented Oct 11, 2017

@isidorn isidorn closed this as completed Oct 19, 2017
@isidorn
Copy link
Contributor

isidorn commented Oct 19, 2017

Fixed via composite bar commits on master

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants