Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal launch errors are not reported properly on Windows #31770

Closed
Tyriar opened this issue Jul 31, 2017 · 1 comment
Closed

Terminal launch errors are not reported properly on Windows #31770

Tyriar opened this issue Jul 31, 2017 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues
Milestone
August 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 31, 2017

Repro:

  1. Add settings "terminal.integrated.shell.windows": "C:\\windows\\Sysnative\\"
  2. Launch terminal

There should be an error message like on Linux/macOS. terminalProcess does not seem to notice that winpty exited.

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label windows VS Code on Windows issues labels Jul 31, 2017
@Tyriar Tyriar added this to the August 2017 milestone Jul 31, 2017
@Tyriar Tyriar self-assigned this Jul 31, 2017
This was referenced Aug 28, 2017
Closed
Open
@Tyriar
Copy link
Member Author

Tyriar commented Aug 28, 2017

Closing as duplicate of #31301 as there's more discussion there.

@Tyriar Tyriar closed this as completed Aug 28, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
1 participant
@Tyriar