Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad action label when having bad debug configuration #3290

Closed
joaomoreno opened this issue Feb 23, 2016 · 3 comments
Closed

Bad action label when having bad debug configuration #3290

joaomoreno opened this issue Feb 23, 2016 · 3 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Feb 2016

Comments

@joaomoreno
Copy link
Member

image

Shouldn't the action label be more like Edit Configuration instead of launch.json?
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2016
@isidorn
Copy link
Contributor

isidorn commented Feb 23, 2016

@weinand and me were discussing this and came to the conlcussion to use launch.json here to make it very clear to the user what will open. I agree Edit Configuration would look nicer
@weinand opinions?

@isidorn isidorn added this to the Feb 2016 milestone Feb 23, 2016
@isidorn
Copy link
Contributor

isidorn commented Feb 24, 2016

After discussing with Andre we agreed on 'Open launch.json' since that is readable and makes it clear to the user what is going to happen.

@isidorn isidorn assigned joaomoreno and unassigned isidorn Feb 24, 2016
@joaomoreno joaomoreno reopened this Feb 26, 2016
@joaomoreno
Copy link
Member Author

Make sure you extract launch.json from the localize call.

@joaomoreno joaomoreno added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
2 participants
@joaomoreno @isidorn