Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense inside JS template literal not showing automatically after typing ${ #32954

Closed
zzJinux opened this issue Aug 22, 2017 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues

Comments

@zzJinux
Copy link

zzJinux commented Aug 22, 2017

  • VSCode Version: 1.15.1
  • OS Version: Windows 10 Pro 1703

Steps to Reproduce:

While typing inside the string interpolation, e.g.${foo}, Intellisense popup for the variable is not shown.

Intellisense regarding the variable's property works perfectly though.
But, It's the variable name that popup doesn't open when typing.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the javascript JavaScript support issues label Aug 22, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 22, 2017

I think we just don't automatically trigger intellisense in this case. If you use the editor.action.triggerSuggest keybinding (ctrl+space on mac) after the { do you see the proper intellisense?

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Aug 22, 2017
@zzJinux
Copy link
Author

zzJinux commented Aug 23, 2017

Yes, I see.
You mean that's intended operation?

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 23, 2017

Glad the workaround works.

This is a bug though. I'm going to change the title of this issue to make the root cause of problem more clear

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Aug 23, 2017
@mjbvz mjbvz changed the title [es6]intellisense inside template literal not working properly Intellisense inside JS template literal not showing automatically after typing ${ Aug 23, 2017
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 16, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 16, 2017

After thinking over this further, I don't believe we should automatically show suggestions when you type ${. Instead my proposal is that we show suggestions once you start typing the next character, such as ${a. This is how quick suggestions work normally in JS.

The reason for this is that the template substitution may contain any expression, and automatically showing suggestions on ${ will make it more annoying to enter expressions such as ${123} or ${[a]}.

Closing this as a duplicate of #34857, which tracks showing quick suggestions on cases such as ${a

@mjbvz mjbvz closed this as completed Oct 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues
Projects
None yet
Development

No branches or pull requests

3 participants