Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code Insiders crashes on every exit on Windows #33016

Closed
alexdima opened this issue Aug 23, 2017 · 6 comments
Closed

VS Code Insiders crashes on every exit on Windows #33016

alexdima opened this issue Aug 23, 2017 · 6 comments
Assignees
@bpasero @Tyriar
Labels
important Issue identified as high-priority
Milestone
August 2017

Comments

@alexdima
Copy link
Member

  • (with Electron 1.7.5)
  • open VS Code
  • close VS Code
  • Observe in process explorer that there is a crash and the crash is presented in the Windows Event Log.
@vscodebot vscodebot bot added the workbench label Aug 23, 2017
@joaomoreno
Copy link
Member

I could repro this in Windows:

  • 1.7.5 x64
  • 1.7.5 ia32
  • 1.7.4 x64

@alexdima
Copy link
Member Author

Electron 1.7.5:

image

Sometimes the greyed out process (marked Suspended) never finishes and this blocks our update mechanism on Windows.

@bpasero bpasero mentioned this issue Aug 23, 2017
Closed
@bpasero
Copy link
Member

bpasero commented Aug 23, 2017

Btw this is electron/electron#10188

@bpasero bpasero added the important Issue identified as high-priority label Aug 23, 2017
@bpasero bpasero added this to the August 2017 milestone Aug 23, 2017
@bpasero
Copy link
Member

bpasero commented Aug 23, 2017

I cannot reproduce in Electron 1.7.3. Unfortunately we need at least 1.7.4 for the fix to have --debug-inspect work in forked processes.

This was referenced Aug 23, 2017
Closed
Closed
@Tyriar Tyriar mentioned this issue Aug 24, 2017
Merged
@Tyriar
Copy link
Member

Tyriar commented Aug 24, 2017

Fixed in #33099

@Tyriar Tyriar closed this as completed Aug 24, 2017
@nileshmali
Copy link

@bpasero This is fixed in https://github.com/electron/electron/releases/tag/v1.7.7

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@Tyriar Tyriar

Labels
important Issue identified as high-priority
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
5 participants
@joaomoreno @bpasero @nileshmali @Tyriar @alexdima