Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] Cannot code fold empty functions #3349

Closed
Tyriar opened this issue Feb 23, 2016 · 4 comments
Closed

[folding] Cannot code fold empty functions #3349

Tyriar opened this issue Feb 23, 2016 · 4 comments
Assignees
@aeschli
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2016

image
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2016
@joaomoreno
Copy link
Member

As designed?

@aeschli
Copy link
Contributor

aeschli commented Feb 24, 2016

Yes, as designed, but maybe the design can be improved :-)

@aeschli aeschli added the editor-folding Editor code folding issues label Feb 24, 2016
@aeschli aeschli added this to the Feb 2016 milestone Feb 24, 2016
@aeschli aeschli changed the title Cannot code fold empty functions [folding] Cannot code fold empty functions Feb 24, 2016
@aeschli aeschli mentioned this issue Feb 24, 2016
Closed
@aeschli
Copy link
Contributor

aeschli commented Feb 24, 2016

To implement that, we would need to have knowledge of the sources language and understand that } is closing a folding region but does not open one.
Without knowing that we would also create a folding region from line 3 to line 5.
image

@aeschli aeschli added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Feb 24, 2016
@aeschli aeschli modified the milestones: Backlog, Feb 2016 Feb 24, 2016
@aeschli aeschli mentioned this issue Feb 24, 2016
Closed
@roblourens roblourens mentioned this issue Nov 14, 2017
Closed
@aeschli
Copy link
Contributor

aeschli commented Nov 21, 2017

Closing as designed.

@aeschli aeschli closed this as completed Nov 21, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joaomoreno @Tyriar @aeschli