Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker: when user start changing color the picker should not easily close #33568

Closed
ghiscoding opened this issue Aug 31, 2017 · 8 comments
Assignees
Labels
editor-color-picker Editor color picker widget issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@ghiscoding
Copy link

ghiscoding commented Aug 31, 2017

  • VSCode Version:
  • OS Version:

Steps to Reproduce:

  1. Hover over a CSS color and the color picker shows up, then move away and the picker goes away which is fine.
  2. Again do an hover over a CSS color again and this time start changing the color and if you have the misfortune of falling outside of the picker area, you lose the original color and your file is now dirty. The only way back is to do an undo (ctrl+z). It happened to me so many times that I slipped outside and lost my original color, the picker is just so small (the size is not the real culprit though) and it's so easy to fall outside.

Reproduces without extensions: Yes

Proposition:
I would rather argue that if the user starts changing the color, then it's most probably he wants to stay in the picker until he decides that the color is acceptable (or not by clicking back on the original color). If you try Chrome for example, the picker stays open until you click away. I think this could be a better approach, and/or add a "x" on the top corner... but please only implement this behavior after the user starts changing the color.
2017-08-31_00-02-11

Compare this to Chrome developer tool, it never closes unless we click outside the picker

I9P35TiGs1

@vscodebot vscodebot bot added the workbench label Aug 31, 2017
@alexdima alexdima added the editor-color-picker Editor color picker widget issues label Oct 26, 2017
@bpasero bpasero removed the workbench label Nov 16, 2017
@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 16, 2017
@iainhallam
Copy link

This has become a bit annoying for me as well; if I start changing the colour, I'd like the picker to stay around until I'm done.

@miguelsolorio
Copy link
Contributor

This is related to #95816 and #130248 where we need to set some padding + offset to increase the hover area

@rebornix rebornix removed their assignment Oct 22, 2021
@eschwartz
Copy link

As soon as I move my cursor a single pixel, the color picker closes

2022-04-01 10 19 19

Version: 1.66.0
Commit: e18005f
Date: 2022-03-30T05:50:04.419Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Darwin x64 19.6.0

@lewallen
Copy link

lewallen commented Sep 12, 2022

As soon as I move my cursor a single pixel, the color picker closes

I have exactly this problem the first time I click a given color box, and then if I use the same color box again right away, the problem goes away.

I used to think I was just being more careful the second time around, but on further inspection I think this is part of the bug.

@ghiscoding
Copy link
Author

Considering that I opened the issue 5 years ago, it doesn't look to be very high on their TODO list, which is sad considering that it's still very annoying 😓

image

@hediet hediet added this to the Backlog milestone Dec 7, 2022
@gnuchanos

This comment was marked as spam.

@elYanuki
Copy link

Please work on this, its should be as simple as adding some padding and changing the colose condition right?. This is just so anoying.

@aiday-mar
Copy link
Contributor

aiday-mar commented Dec 5, 2023

Hi earlier this year we have made it that when a hover is focused, it should no longer close when hovering out of it. This applied to the color picker, and you can use this feature to keep it open. Additionally if you want to make the color picker and the other hovers disappear less quickly, you can configure the hiding delay with the setting editor.hover.hidingDelay. The default is 300ms but it can be increased if you wish so.

This issue will be closed. If you have more improvements suggestions or bugs to fix, you can open a new issue in the vscode repo.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-color-picker Editor color picker widget issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests