Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore ways how to make Electron adoptions less painful #34395

Closed
Tyriar opened this issue Sep 14, 2017 · 3 comments
Closed

Explore ways how to make Electron adoptions less painful #34395

Tyriar opened this issue Sep 14, 2017 · 3 comments
Assignees
Labels
debt Code quality issues electron Issues and items related to Electron engineering VS Code - Build / issue tracking / etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2017

No description provided.

@Tyriar Tyriar added debt Code quality issues electron Issues and items related to Electron labels Sep 14, 2017
@Tyriar Tyriar added this to the September 2017 milestone Sep 14, 2017
@Tyriar Tyriar self-assigned this Sep 14, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Sep 14, 2017

Upgrading Electron is currently more difficult than we would like. The August release is a great illustration of the issues we can encounter, we were still on v1.6.6 which was done in the May release so we were jumping ahead several months worth of versions. We had previously done some testing in v1.7.x and found that there was a debug-related regression (electron/electron#9696) which was only fixed in v1.7.4.

Here's roughly what happened:

  • Upgraded Insiders to use Electron v1.7.4
  • Upgraded Insiders to use Electron v1.7.5 when it became available
  • After several days on v1.7.5 we discovered that closing VS Code actually crashed it on Windows (command + <number> key behaviers #10188), this regressed in v1.7.4 which was required due to the debug regression
  • We built Electron v1.7.3 with the fix for the debug regression backported

Maybe we could have caught these issues sooner, or even better have reported upstream and got them fixed faster.

One idea we've been throwing around is to set up a branch that upgrades it's Electron version and then CI builds and runs our test suites. This would encourage us to build out the smoke test suite. When and who would start testing these new versions, ie. when does it land in Insiders?

We should also try accepting new patch Electron versions more aggressively (1.6.6 -> 1.6.latest) as these should be lower risk updates.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 14, 2017

/cc @bpasero

@Tyriar
Copy link
Member Author

Tyriar commented Sep 22, 2017

New release process we came up with: electron/electron#10558

The main idea I was pushing for was moving to SemVer and making minor and patch versions as low risk as possible to update.

@Tyriar Tyriar modified the milestones: September 2017, October 2017 Sep 26, 2017
@Tyriar Tyriar modified the milestones: October 2017, November 2017 Oct 30, 2017
@bpasero bpasero added engineering VS Code - Build / issue tracking / etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 11, 2017
@Tyriar Tyriar modified the milestones: November 2017, Backlog Dec 7, 2017
@Tyriar Tyriar closed this as completed Sep 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues electron Issues and items related to Electron engineering VS Code - Build / issue tracking / etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants