Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] auto close triggers on undo/redo and breaks undo/redo history #34484

Closed
coderpatsy opened this issue Sep 15, 2017 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded

Comments

@coderpatsy
Copy link

  • VSCode Version: 1.16.1
  • OS Version: Windows 8.1

Steps to Reproduce:

  1. In a html file, type (not copy) <span>test
  2. Undo to before step 1
  3. Redo

Now you cannot redo the typing of test or any edits after that point, as the auto close overwrote the undo/redo history.

Alternate steps:

  1. Delete an opening tag not immediately followed by its closing tag; e.g. delete the <span> of <span>test</span>
  2. Undo your deletion

Reproduces without extensions: Yes

Expected behavior:

VSCode does not perform any new automatic formatting on undo/redo.

@aeschli aeschli changed the title HTML auto close triggers on undo/redo and breaks undo/redo history [html] auto close triggers on undo/redo and breaks undo/redo history Sep 18, 2017
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Sep 18, 2017
@aeschli aeschli added this to the Backlog milestone Sep 18, 2017
@aeschli
Copy link
Contributor

aeschli commented Sep 18, 2017

There's currently no way on the extension host to know the input method of a document change.

@aeschli
Copy link
Contributor

aeschli commented Sep 21, 2018

#52777 is about issues due to programmatic changes

@aeschli aeschli closed this as completed Sep 21, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 5, 2018
@aeschli aeschli reopened this Sep 16, 2021
@aeschli aeschli modified the milestones: Backlog, September 2021 Sep 16, 2021
@rchiodo rchiodo added the verified Verification succeeded label Sep 29, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Sep 29, 2021

This is still reproing for me? Maybe I misunderstood what the fix did:

undoSpan

@rchiodo rchiodo reopened this Sep 29, 2021
@rchiodo rchiodo added verification-found Issue verification failed and removed verified Verification succeeded labels Sep 29, 2021
@aeschli aeschli added verification-needed Verification of issue is requested and removed verification-found Issue verification failed labels Sep 30, 2021
@rchiodo rchiodo added the verified Verification succeeded label Sep 30, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Sep 30, 2021

/verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@bpasero @aeschli @chrmarti @coderpatsy @rchiodo and others