Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Staged (Amend) asks to stage changes and then fails #35185

Closed
chrmarti opened this issue Sep 26, 2017 · 2 comments · Fixed by #35700
Closed

Commit Staged (Amend) asks to stage changes and then fails #35185

chrmarti opened this issue Sep 26, 2017 · 2 comments · Fixed by #35700
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone
January 2018

Comments

@chrmarti
Copy link
Collaborator

  • VSCode Version: Code - Insiders 1.17.0-insider (a5210bc, 2017-09-26T05:24:48.911Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions: none

Testing #34963

Steps to Reproduce:

  1. Have some unstaged changes, none staged
  2. Commit Staged (Amend)
  3. Dialog asks if I want to stage the changes
  4. Click Yes
  5. 🐛 Message telling me that there are no changes to commit
@chrmarti chrmarti added the git GIT issues label Sep 26, 2017
@vscodebot vscodebot bot added the insiders label Sep 26, 2017
@joaomoreno joaomoreno added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Sep 27, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Sep 27, 2017
@chrmarti chrmarti removed the insiders label Sep 27, 2017
@dKab
Copy link
Contributor

dKab commented Sep 29, 2017 •
edited
Loading

Hi, I'm working on it. The PR will be ready shortly!

@dKab dKab mentioned this issue Oct 6, 2017
Merged
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Nov 23, 2017
@joaomoreno
Copy link
Member

For repro: make sure you have "git.enableSmartCommit": false.

@joaomoreno joaomoreno modified the milestones: Backlog, December 2017 Dec 11, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
@octref octref added the verified Verification succeeded label Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

Commit unstaged files after pop-up confirmation (#35185)
4 participants
@joaomoreno @octref @dKab @chrmarti