Snippet used when creating extensions.json puts cursor in the wrong place

[ramya-rao-a]

Testing #29242

In multi-root set up, the command Extensions: Configure Recommended Extensions (Workspace) creates the extensions.json file as below

The cursor should be inside the [].
Instead the cursor is just before []

[aeschli]

@sandy081 Can you give more information what's happening in the background and why you think this is something I can fix?

[sandy081]

@aeschli Here is my schema for extensions/recommendations

{
	id: ExtensionsConfigurationSchemaId,
	type: 'object',
	title: localize('app.extensions.json.title', "Extensions"),
	properties: {
		recommendations: {
			type: 'array',
			description: localize('app.extensions.json.recommendations', "List of extensions recommendations. The identifier of an extension is always '${publisher}.${name}'. For example: 'vscode.csharp'."),
			items: {
				type: 'string',
				pattern: EXTENSION_IDENTIFIER_PATTERN,
				errorMessage: localize('app.extension.identifier.errorMessage', "Expected format '${publisher}.${name}'. Example: 'vscode.csharp'.")
			},
		},
	}
}

recommendations is of type array. When a user types recommendations I think you are automatically writing empty array. I think the bug here is that, cursor is not placed inside array.

[aeschli]

When completing 'recommendations' with code assist, you get

The Extensions: Configure Recommended Extensions (Workspace) seems to either create a new file or open the existing file and add recommendations. In both cases the cursor is at the end.

How do you insert recommendations? You would have to add it as snippet. Probably like that: https://github.com/Microsoft/vscode/blob/5b76a1d27f75814a4494aad6d909a01436c61f0a/src/vs/workbench/api/electron-browser/mainThreadEditor.ts#L358, but Joh would know.

[sandy081]

Ah ok. This is while creation. Could be that I placing the cursor there. Thanks @aeschli for insight.