Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Code for Windows 10 doesn't restore all windows. On system fail. #35383

Closed
MichelDiz opened this issue Sep 29, 2017 · 5 comments
Closed

Visual Code for Windows 10 doesn't restore all windows. On system fail. #35383

MichelDiz opened this issue Sep 29, 2017 · 5 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-electron Electron-VS Code issues

Comments

@MichelDiz
Copy link

  • VSCode Version: 1.16.1 2017-09-14
  • OS Version: Windows 10 1703 Build 15063.608

Steps to Reproduce:

1.Open 3 projects. Separate. Force a turn off of the computer. To simulate a fail of energy or some power accident.
2. Reboot Windows. Reopen the VS code. Just opens one project that wasn't open before. 3 other project was gone.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the workbench label Sep 29, 2017
@MichelDiz MichelDiz changed the title Visual Code for Windows doesn't restore all windows. On system fail. Visual Code for Windows 10 doesn't restore all windows. On system fail. Sep 29, 2017
@sandy081 sandy081 assigned bpasero and unassigned sandy081 Sep 29, 2017
@bpasero
Copy link
Member

bpasero commented Sep 30, 2017

@MichelDiz does it change if you configure "window.restoreWindows": "all"?

@bpasero bpasero added the info-needed Issue requires more information from poster label Sep 30, 2017
@bpasero bpasero added this to the Backlog milestone Sep 30, 2017
@MichelDiz
Copy link
Author

I'm using it from the beginning - forgot to report it.

@bpasero
Copy link
Member

bpasero commented Sep 30, 2017

Yeah, I think a crash like that is hard for us to restore properly because we keep the state of opened windows (and any UI state) only when shutdown happens normally. Related: #12058

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Sep 30, 2017
@MichelDiz
Copy link
Author

Could do an "instant save" of the state used in each window. Tracking the user environments "live" and caching it. VScode has an "Save automatically" this tracking windows thing could be a native feature instead of a bug.

@bpasero bpasero added workbench-electron Electron-VS Code issues and removed workbench labels Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 15, 2017
@bpasero
Copy link
Member

bpasero commented May 11, 2018

Closing as duplicate of #12058

@bpasero bpasero closed this as completed May 11, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label May 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-electron Electron-VS Code issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @MichelDiz @sandy081