Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Code Folding in larger files slows down editor #3582

Closed
kuechlerm opened this issue Mar 1, 2016 · 4 comments
Closed

[folding] Code Folding in larger files slows down editor #3582

kuechlerm opened this issue Mar 1, 2016 · 4 comments
Assignees
Labels
debt Code quality issues editor-folding Editor code folding issues
Milestone

Comments

@kuechlerm
Copy link

In 0.10.10-insider folding more than about 3000 lines of xml slows down the editor.
Specifically moving the cursor takes seconds.

Should be reproducible with

`
1

`

Addition: If the cursor is not located in the block that gets folded, there is no lag.

@isidorn isidorn added the editor-folding Editor code folding issues label Mar 1, 2016
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Mar 1, 2016
@aeschli aeschli added this to the March 2016 milestone Mar 1, 2016
@aeschli aeschli changed the title Code Folding in larger files slows down editor [folding] Code Folding in larger files slows down editor Mar 1, 2016
@egamma egamma mentioned this issue Mar 2, 2016
82 tasks
@aeschli
Copy link
Contributor

aeschli commented Mar 2, 2016

@kuechlerm Is that what you tried?

  • have a large XML document
  • set the cursor inside
  • fold the top node

@kuechlerm
Copy link
Author

@aeschli Yes, but so be more specific:

  • have a XML doc with a large node (more then 3000 elements) and a small node (place for cursor movement)
  • place cursor inside large node
  • use shortcut or mouse to fold node

Result:

  • no cursor movement for a while (~2 seconds)
  • overall slower cursor movement in the rest of the file from here on

Placing the cursor outside the node and then closing the large node with a mouse click sometimes seemed to have less or no lag, but I cannot reproduce that with certainty.

Unfolding restores normal cursor speed.

@aeschli
Copy link
Contributor

aeschli commented Mar 4, 2016

The problem with folding a full document to one line is that we collapse all decorators to that one line. Decorators are used for error markers, git markers, but also for tracking the folding regions.

We have ideas on how to reduce the number of decorators used for folding to improve the performance of this scenario. Bur not for March.

@aeschli aeschli modified the milestones: Backlog, March 2016 Mar 4, 2016
@aeschli aeschli added debt Code quality issues and removed important Issue identified as high-priority labels Mar 4, 2016
@aeschli
Copy link
Contributor

aeschli commented Mar 4, 2016

I created #3725.

@aeschli aeschli closed this as completed Mar 4, 2016
@aeschli aeschli removed the bug Issue identified by VS Code Team member as probable bug label Mar 18, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues editor-folding Editor code folding issues
Projects
None yet
Development

No branches or pull requests

3 participants