Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad AA on characters immediately following emojis #35994

Closed
chrmarti opened this issue Oct 10, 2017 · 3 comments
Closed

Bad AA on characters immediately following emojis #35994

chrmarti opened this issue Oct 10, 2017 · 3 comments
Assignees
@Tyriar
Labels
invalid Issue identified as not relevant or not valid terminal General terminal issues that don't fall under another label
Milestone
Backlog

Comments

@chrmarti
Copy link
Collaborator

1.17.1 candidate build, found verifying #35656

  • VSCode Version: Code 1.17.1 (1e9d365, 2017-10-10T14:10:17.189Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions: A few

image
@chrmarti chrmarti added the terminal General terminal issues that don't fall under another label label Oct 10, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 10, 2017

The overlapping thing is as designed as it's how emoji's are sized within the shell. I do notice there is some bad AA on the char on top of the emoji though, that can be fixed.

@Tyriar Tyriar changed the title Emoji overlaps with following character Bad AA on characters immediately following emojis Oct 10, 2017
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Oct 10, 2017
@Tyriar Tyriar added this to the October 2017 milestone Oct 10, 2017
@Tyriar Tyriar mentioned this issue Oct 13, 2017
Closed
@Tyriar Tyriar modified the milestones: October 2017, Backlog Oct 13, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2018

Upstream: xtermjs/xterm.js#1060

@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2018

Would be fixed by xtermjs/xterm.js#1059

@Tyriar Tyriar closed this as completed Sep 17, 2018
@Tyriar Tyriar added invalid Issue identified as not relevant or not valid and removed bug Issue identified by VS Code Team member as probable bug labels Sep 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
invalid Issue identified as not relevant or not valid terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Tyriar @chrmarti