Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated terminal renders fonts incorrectly since 1.17.1 #36160

Closed
xpl opened this issue Oct 12, 2017 · 4 comments
Closed

Integrated terminal renders fonts incorrectly since 1.17.1 #36160

xpl opened this issue Oct 12, 2017 · 4 comments
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@xpl
Copy link

xpl commented Oct 12, 2017

  • VSCode Version: 1.17.1
  • OS Version: MacOS Sierra

"Monaco" font on my MacOS now looks like this in the integrated terminal (with "terminal.integrated.fontFamily": "Monaco")

screen shot 2017-10-12 at 21 45 24

This is how it looks in the Terminal.app (i.e. how it should look):

screen shot 2017-10-12 at 21 44 23

Steps to Reproduce:

  1. Set "terminal.integrated.fontFamily": "Monaco" in the Settings
  2. Open Integrated Terminal, compare rendering to Terminal.app (with the same font settings chosen)

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Oct 12, 2017
@alohaninja
Copy link

alohaninja commented Oct 12, 2017 •
edited
Loading

just saw this - opened a similar issue here: #36172

I'm betting it has something to do with the new rendering engine: https://code.visualstudio.com/blogs/2017/10/03/terminal-renderer

I'm excited to see it's 45x faster - let's just get the kinks worked out with rendering the fonts - its primary job. ;-)

@svictoreq
Copy link

I have the same problem, but in the Insiders version, the font rendering is better. For example, here's the stable version:
image

And here's the Insiders version:
image

The font used is Fira Code.

@emelent
Copy link

emelent commented Oct 16, 2017 •
edited
Loading

Yep, having the same problem here on macOS(Sierra)
screen shot 2017-10-16 at 4 23 06 pm

@Tyriar
Copy link
Member

Tyriar commented Oct 17, 2017

Duplicate #35991

Should be fixed in 1.17.2 that released today.

@Tyriar Tyriar closed this as completed Oct 17, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@xpl @Tyriar @chrmarti @emelent @alohaninja @svictoreq