Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about VSCode terminal #36805

Closed
takkuumi opened this issue Oct 24, 2017 · 1 comment
Closed

Question about VSCode terminal #36805

takkuumi opened this issue Oct 24, 2017 · 1 comment
Assignees
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code) terminal Integrated terminal issues

Comments

@takkuumi
Copy link

takkuumi commented Oct 24, 2017

VSCode terminal use canvas to show command result.
it's so amazing! i wonder how it's done?

like this?
input command -> native terminal -> output command -> syntax to html -> draw html to canvas

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Oct 24, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 24, 2017

You can check out this blog post I wrote about it for a high-level summary: https://code.visualstudio.com/blogs/2017/10/03/terminal-renderer

Here's the PR that goes into more technical details: xtermjs/xterm.js#938

Essentially this is how it was before:

input -> pty -> output -> create html based on output

And now:

input -> pty -> output -> draw text to canvas based on output

@Tyriar Tyriar closed this as completed Oct 24, 2017
@Tyriar Tyriar added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Oct 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code) terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants