Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick suggestions not shown for ${| template string #37176

Closed
mjbvz opened this issue Oct 30, 2017 · 5 comments
Closed

Quick suggestions not shown for ${| template string #37176

mjbvz opened this issue Oct 30, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues plan-item VS Code - planned item for upcoming
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 30, 2017

Followup on #34857

repo

  1. In a js file, type:
`${|`
  1. Then type c at the |

Bug
Quick suggestions are not shown in this case

@mjbvz mjbvz added the javascript JavaScript support issues label Oct 30, 2017
@mjbvz mjbvz self-assigned this Oct 30, 2017
@ghost
Copy link

ghost commented Oct 30, 2017

I said it cca 5 months ago.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Oct 30, 2017

@Mlocik97-issues This bug tracks the specific case:

`${|`

Case such as:

`${|}`
`${| `
`${| x`

were fixed by #34857

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Oct 30, 2017
@mjbvz
Copy link
Collaborator Author

mjbvz commented Oct 30, 2017

Basic issue is that we can't distinguish:

`${`

From valid code like:

`${`abc`}`

In that case, quick suggestions should not be shown since you would be inside of a string again

@mjbvz mjbvz added the *as-designed Described behavior is as designed label Nov 16, 2017
@mjbvz mjbvz added this to the November 2017 milestone Dec 1, 2017
@mjbvz mjbvz removed the *as-designed Described behavior is as designed label Dec 1, 2017
@mjbvz mjbvz modified the milestones: November 2017, Backlog Dec 1, 2017
@mjbvz mjbvz modified the milestones: Backlog, February 2018 Feb 15, 2018
@mjbvz mjbvz added the plan-item VS Code - planned item for upcoming label Feb 15, 2018
@mjbvz mjbvz modified the milestones: February 2018, March 2018 Feb 27, 2018
@mjbvz mjbvz closed this as completed in eb2b0df Mar 16, 2018
@roblourens
Copy link
Member

@mjbvz seems the same as 1.21. I can trigger manually but it doesn't autotrigger when I type c.

@roblourens roblourens reopened this Mar 29, 2018
@roblourens roblourens added the verification-found Issue verification failed label Mar 29, 2018
@rebornix rebornix modified the milestones: March 2018, April 2018 Mar 29, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 3, 2018

Broke when I changed to using selector matching instead of direct comparisons for scopes. Will require a fix on vscode textmate

@mjbvz mjbvz removed the verification-found Issue verification failed label Apr 3, 2018
@mjbvz mjbvz closed this as completed in 5900899 Apr 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

3 participants