Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS autoimport should provide qualification to make imported entries unique #37241

Closed
dbaeumer opened this issue Oct 31, 2017 · 2 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues

Comments

@dbaeumer
Copy link
Member

Testing: #37177

  • JS project
  • file provide1.js
export function foo() {
}

export function foo1() {
}
  • file provide2.js
export function foo() {
}

export function foo2() {
}
  • file consume.js
function bar() {
}
  • inside body bar type foo1, select the symbol. Notice import generated correctly
  • inside body bar type foo2, select the symbol. Notice import generated correctly
  • inside body bar type foo

Observe:

  • there is only one foo
  • IMO there should be two, each qualified with the file exporting it
  • select foo
  • an import is added. I couldn't come up with a rule which on is taken.
@vscodebot vscodebot bot added the javascript JavaScript support issues label Oct 31, 2017
@dbaeumer
Copy link
Member Author

Same happens with TS.

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 1, 2017

Duplicate of #37283. Please try this in the next insiders build

@mjbvz mjbvz marked this as a duplicate of #37283 Nov 1, 2017
@mjbvz mjbvz closed this as completed Nov 1, 2017
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues
Projects
None yet
Development

No branches or pull requests

2 participants