Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench.confirmChangesToWorkspaceFromExtensions should not be a setting #37298

Closed
alexdima opened this issue Oct 31, 2017 · 2 comments
Closed

workbench.confirmChangesToWorkspaceFromExtensions should not be a setting #37298

alexdima opened this issue Oct 31, 2017 · 2 comments
Assignees
@bpasero
Labels
*as-designed Described behavior is as designed

Comments

@alexdima
Copy link
Member

Testing #37133

IMHO we should store the answer to these types of "Never ask me again", "always", etc. questions in another type of storage than in the settings.
@bpasero
Copy link
Member

bpasero commented Oct 31, 2017

@alexandrudima the reason I decide to store it in settings is so that the user has a way to unset this again. How would a user otherwise get back to the state where the checkbox is not checked if the dialog is never showing up again?

@bpasero bpasero added the *as-designed Described behavior is as designed label Oct 31, 2017
@alexdima
Copy link
Member Author

Ugh, this is a nasty problem indeed.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @alexdima