Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer indication of what is input and what is output in debug console #37363

Closed
mjbvz opened this issue Oct 31, 2017 · 7 comments
Closed

Clearer indication of what is input and what is output in debug console #37363

mjbvz opened this issue Oct 31, 2017 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 31, 2017

Problem
In the debug console, it can sometimes be difficult to tell what is text you entered and what is the evaluated result:

screen shot 2017-10-31 at 4 38 10 pm

This was improved with #35324 for literals but I still like how Chrome and Safari have little icons (and separator lines) to indicate this:

screen shot 2017-10-31 at 4 37 26 pm

@mjbvz mjbvz assigned roblourens and isidorn and unassigned roblourens Oct 31, 2017
@roblourens
Copy link
Member

And F12. Don't forget Edge!

@isidorn
Copy link
Contributor

isidorn commented Nov 1, 2017

We had these lines before and decided against it, since it is not always nicely grouped two by two. Sometimes some output comes and then the lines would not look so nice.
@mjbvz you can probaly download a build from a year ago to check it out
@weinand do you remember the other reasons why we removed this?

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Nov 1, 2017
@isidorn isidorn added this to the Backlog milestone Nov 1, 2017
@weinand
Copy link
Contributor

weinand commented Nov 14, 2017

Let's try to use the icons and see how this looks and feel.

If we like them, then we can try the separator lines (since we made some improvements to the output stream, it could be that some of the old issues no longer exist).

@weinand weinand modified the milestones: Backlog, On Deck Nov 14, 2017
@isidorn
Copy link
Contributor

isidorn commented Oct 8, 2019

We could look into improving this in the future.
fyi @dgozman since you added colors in your version to make this clearer.

@isidorn
Copy link
Contributor

isidorn commented Dec 2, 2019

This is how it looks, try it out and let me know.
For the arrows I am using octicon small arrows. @misolori feedback welcome if we have some better icons. Though I peronsally like these.

@weinand already pointed out that the tree expando should be closer to the element, I will look into if that is possible

Screenshot 2019-12-02 at 16 27 33

@isidorn isidorn added the verification-needed Verification of issue is requested label Dec 2, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 2, 2019

Even though the arrows are centered due to the way how the brain processes these images one looks more to the left, and one more to the right and the whole hing looks a bit messy. Suggestions welcome on how to improve!

@jrieken jrieken added the verified Verification succeeded label Dec 4, 2019
@jrieken
Copy link
Member

jrieken commented Dec 4, 2019

Screenshot 2019-12-04 at 12 26 45

It is there but not really pretty, esp when expanded but I believe we already talked about it

@isidorn isidorn added the release-notes Release notes issues label Dec 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants