Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php function closure bug after <<<A A; (realy hard to read code without fix) #37494

Closed
peon501 opened this issue Nov 2, 2017 · 5 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) php PHP support issues

Comments

@peon501
Copy link

peon501 commented Nov 2, 2017

php function closure bug.
cant minimise function when <<<A A; is written inside.

  • VSCode Version: newest
  • OS Version: win 8.1

Steps to Reproduce:

  1. write function
    image

image

@peon501 peon501 changed the title php function closure bug after <<<A A; php function closure bug after <<<A A; (realy hard to read code without it) Nov 2, 2017
@peon501 peon501 changed the title php function closure bug after <<<A A; (realy hard to read code without it) php function closure bug after <<<A A; (realy hard to read code without fix) Nov 2, 2017
@octref octref assigned aeschli and roblourens and unassigned aeschli Nov 2, 2017
@roblourens
Copy link
Member

Folding is mainly indentation-based right now, this is one case where that doesn't look great.

#3422

@roblourens roblourens added *duplicate Issue identified as a duplicate of another issue(s) php PHP support issues labels Nov 2, 2017
@peon501
Copy link
Author

peon501 commented Nov 3, 2017

I hope you will do something about it. Its really annoying...

@peon501
Copy link
Author

peon501 commented Nov 3, 2017

yeah thats the problem because you cant use tab, space or anything before A;, so indentation-based code dont fit in this situation. Can you make exception for this in indentation-based code or it is hard to do?

@roblourens
Copy link
Member

I see the problem, the issue I linked is for looking at other ways of doing folding.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 17, 2017
@aeschli aeschli reopened this May 14, 2018
@aeschli
Copy link
Contributor

aeschli commented May 14, 2018

There's now API for language extensions to contribute a folding provider.
The built-in PHP extension only provides basic editing support and doesn't contain a parser.

So to get this implemented, please file a feature request against one the PHP extensions: e.g. https://github.com/felixfbecker/vscode-php-intellisense or https://github.com/bmewburn/vscode-intelephense

@aeschli aeschli closed this as completed May 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) php PHP support issues
Projects
None yet
Development

No branches or pull requests

3 participants