Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folding is whitespace sensitive #3805

Closed
ADCJustinH opened this issue Mar 8, 2016 · 2 comments
Closed

Folding is whitespace sensitive #3805

ADCJustinH opened this issue Mar 8, 2016 · 2 comments

Comments

@ADCJustinH
Copy link

In typescript this function (being ported from js) does not fold correctly due to the second line of the function being improperly indented. That seems really wonky, why does it care at all about indentation? Should it not just fold to the closing '}' for the function?

private initPortletTools(): void {
        // handle portlet remove
    $('body').on('click', '.portlet > .portlet-title > .tools > a.remove', function(e) {
        ...
        portlet.remove();
    });
}
@Growiel
Copy link

Growiel commented Mar 8, 2016

According to the release notes:

The folding regions are evaluated solely based on the indentation of each line. This first version does not yet support language agnostic folding regions, or folding markers. This is in discussion for an upcoming release (see issue #3422).

So for now I'd say for now it "intended" behavior.

@weinand
Copy link
Contributor

weinand commented Mar 8, 2016

@ADCJustinH yes, for now this is the intended behavior.

@weinand weinand closed this as completed Mar 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants