[TextEditorOptions] support end of line

[SamVerschueren]

In the EditorConfig plugin, we want to implement end_of_line as well. In the latest VS Code release, I noticed that we have a files.eol setting now. Would it be possible to expose this to the TextEditorOptions interface to set this on the fly?

// @alexandrudima

[alexdima]

@SamVerschueren I've just added a way to do that this morning via textEditor.edit().

We thought to put it on the editBuilder since it changes the document content.

fyi @jrieken

[alexdima]

The relevant commit is 45906d9

[SamVerschueren]

Awesome, thanks! The only thing that's missing for an entire EditorConfig integration is charset. There is already an open issue for this #824

[alexdima]

fyi @bpasero editor config can contain charset configurations.

Also missing from the API: trim_trailing_whitespace and insert_final_newline, but I think there are workarounds for these last two (submitting edits to the text editor).

[bpasero]

@alexandrudima would it make sense to have charset on the model and me picking it up from there?

[alexdima]

@bpasero I don't think that would work, because the charset should be used when creating the model, it would be too late to have it as a setting on a model.

[SamVerschueren]

Maybe we should track that in a different issue?

[SamVerschueren]

Is an API for changing charset somewhere on the roadmap? It's the last missing piece for EditorConfig.

[jrieken]

No plans yet, will also be a little extra work as for us. I have created #5318 for taht

[SamVerschueren]

Thanks @jrieken