Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest accessibility: make announcements more concise #3861

Closed
isidorn opened this issue Mar 8, 2016 · 2 comments
Closed

Suggest accessibility: make announcements more concise #3861

isidorn opened this issue Mar 8, 2016 · 2 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 8, 2016

We got feedback from users for debug accessibility to make the announcements as concise as possible. Here are some ideas on how to make it more concise for suggest widget:

  1. Do not announce 'suggestion' after each suggestion, instead of that announce when suggest widget opened and closed - that way the user will know that what he is hearing are suggestions inside the widget
  2. instead of saying 'name, suggestion accepted' just say 'name, accepted'

@zersiax opinions very welcome

@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 8, 2016
@zersiax
Copy link

zersiax commented Mar 8, 2016 via email

@alexdima alexdima added this to the March 2016 milestone Mar 8, 2016
@alexdima
Copy link
Member

@isidorn There is no need to announce the suggest widget opening, that would only add more noise. There is still a need to announce "suggestion" after each suggestion as now the entire line gets read again on cursor up/down. I will write down more details in #3787. I have shortened the message when accepting a suggestion, as per your point number 2.

@zersiax I will describe shortly the current state of the suggest widget in #3787

@alexdima alexdima assigned isidorn and unassigned alexdima Mar 21, 2016
@isidorn isidorn added the verified Verification succeeded label Mar 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants