Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show line number on search #39219

Closed
yuric18 opened this issue Nov 28, 2017 · 10 comments
Closed

Show line number on search #39219

yuric18 opened this issue Nov 28, 2017 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality release-notes Release notes issues search Search widget and operation issues ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@yuric18
Copy link

yuric18 commented Nov 28, 2017

Hi, I would like to request the feature of showing the archive line number next to the code found when I search some piece of code. I think it could be added as a setting such as "search.lineNumbers: "on"||"off" just like "editor.lineNumbers" setting. Do you guys think that is possible?

Just an example below:
image

@vscodebot vscodebot bot added the search Search widget and operation issues label Nov 28, 2017
@roblourens roblourens added feature-request Request for new features or functionality ux User experience issues labels Nov 28, 2017
@roblourens
Copy link
Member

Reasonable request, but since the viewlet is so narrow, it would have to take up horizontal space or get cut off.

@yuric18
Copy link
Author

yuric18 commented Nov 28, 2017

What if it's enabled automatically when expanding the viewlet? Just like the extension icons and other info? Just like below.

image
image

This was referenced Dec 5, 2017
@dan-h-ch
Copy link

+1 for this - moving over from another IDE I use this to quickly ascertain if results are in same method so I don't have to worry.

@adammhaile
Copy link

+1 as well. It's the one thing I miss from Atom

@zhaoterryy
Copy link

+1

@gianlucaborello
Copy link

I probably spend 30% of my vscode time navigating through search results like a maniac, so having line numbers would be a terrific productivity improvement, especially now that we have "search.location": "panel". Thanks!

@vresch
Copy link

vresch commented Jul 11, 2018

+1 After Atom looks like an obvious functionality

@rob-ubnt
Copy link

+1 for this. JetBrains does this and it's incredibly helpful.

@microsoft microsoft locked as spam and limited conversation to collaborators Jul 11, 2018
@microsoft microsoft unlocked this conversation Sep 13, 2018
@roblourens roblourens added this to the October 2018 milestone Oct 9, 2018
@onqtam
Copy link

onqtam commented Oct 19, 2018

how to get this to work?

I got the version from 3 days ago and cannot find the option

@roblourens roblourens added the verification-needed Verification of issue is requested label Oct 31, 2018
@RMacfarlane
Copy link
Contributor

@onqtam The setting is search.showLineNumbers. This is available in the current insiders version, 1.29. You can download the insiders version or wait until our monthly release next week

@RMacfarlane RMacfarlane added the verified Verification succeeded label Nov 1, 2018
@roblourens roblourens added the release-notes Release notes issues label Nov 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality release-notes Release notes issues search Search widget and operation issues ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

10 participants