Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation improvements #3922

Closed
3 tasks done
isidorn opened this issue Mar 9, 2016 · 1 comment
Closed
3 tasks done

Indentation improvements #3922

isidorn opened this issue Mar 9, 2016 · 1 comment

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 9, 2016

Assignees:

We have improved our indentation support. Verify:

New defaults

  • By default we ship with editor.detectIndentation = true, editor.tabSize = 4, editor.insertSpaces = false.
  • When editor.detectIndentation is set to true, and the file has sufficient hints (it is not empty, it has indented content), editor.tabSize and editor.insertSpaces will be guessed from the file contents.
  • Since the detection code now kicks in by default, please open some files from other OSS projects and check if the indentation is guessed correctly.
  • Migration story: Make sure you get a warning and a notification message if either editor.tabSize, editor.inserSpaces are set to 'auto' and a custom hover message on the values in settings.

Note: By design, editor.tabSize will be guessed only to 2, 4, 6 or 8.

Status Bar

  • Status bar always shows indentation status and clicking on it shows indentation actions
  • 'Detect indentation from Content' guesses the indentation in the current editor from the content
  • All the configured indentation is preserved in a vscode session for a file - if you open the same file in a new editor it should have the same indentation settings
@isidorn isidorn added this to the March 2016 milestone Mar 9, 2016
@isidorn
Copy link
Contributor Author

isidorn commented Mar 9, 2016

@alexandrudima please update this test plan item as you see fit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants