Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on documentation links leads to the wrong link #39864

Closed
ezra100 opened this issue Dec 7, 2017 · 2 comments
Closed

Clicking on documentation links leads to the wrong link #39864

ezra100 opened this issue Dec 7, 2017 · 2 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@ezra100
Copy link

ezra100 commented Dec 7, 2017

  • VSCode Version: Windows 10
  • OS Version: 1.18.1

Steps to Reproduce:

  1. Open a JS/TS file and insert the following code:
/**
    * @see {@link https://api.jquery.com/each/}
    */
function each()

each()
  1. Hover over the function call 'each'.
  2. Once the popup window shows click the link.

Expected behavior:
The following link should be open
Actual behavior:
The closing bracket is added to the link so it goes to

I'd think that the problem was with the documentation (that it's missing a space before the closing bracket) but since clicking the link on the document itself (not in the popup window) goes to the right link than I guess the problem is with the parsing in the documentation popup window.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the api label Dec 7, 2017
@isidorn isidorn removed the api label Dec 7, 2017
@alexdima
Copy link
Member

alexdima commented Dec 8, 2017

This link comes from the TypeScript hover.

@alexdima alexdima assigned mjbvz and unassigned alexdima Dec 8, 2017
@mjbvz mjbvz added typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Dec 8, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 8, 2017

Yes, jsdoc links are currently not parsed properly. Tracked upstream by microsoft/TypeScript#16498

@mjbvz mjbvz closed this as completed Dec 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants