Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjacent characters are given a lower rank in command palette than distant characters #40044

Closed
brandondrew opened this issue Dec 11, 2017 · 5 comments
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues

Comments

@brandondrew
Copy link

When using the command palette, ordering of results fails to take into account adjacency of characters.

Whether this is a bug report or a feature request really depends on whether effort was already made to make the search results account for adjacency or not. The only other issue I can find related to this is #21019, but that seems to be dealing with a different matter, so I will include version information, but I'm proceeding under the premise that this is a request for a new feature rather than a bug report.

The case for the value of this feature

image

Although the ability to search through commands without having to type in every consecutive character is valuable, it seems to me that users will virtually never want or expect the results of their search to prioritize results with a disconnected match above results with a connected match. In the image above, I typed "vim" and expected to see all commands related to Vim mode at the top of the list. I cannot imagine a case where I would type in the characters vim and expect "View: Minimize Other Editor Groups" at the top of the list. If I were looking for "View: Minimize Other Editor Groups", I would expect to have to type more characters, and certainly be prepared to do so. I would most likely type view:moeg—unless the command I wanted rose to the top before I finished typing that.

Hopefully the example I've given is enough to demonstrate that the behavior I'm describing would be preferable. But if I've left any questions unanswered, please ask for more information.

Thanks!

  • VSCode Version: Code 1.18.1 (929bacb, 2017-11-16T18:23:26.125Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions: the listing length exceeds browsers' URL characters limit

Steps to Reproduce:

  1. Ensure that you have the Vim plugin installed.
  2. Open command palette with F1 or P.
  3. Type "vim".
  4. Note that expected results appear at the bottom of the list.
@vscodebot vscodebot bot added the editor label Dec 11, 2017
@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues and removed workbench labels Dec 12, 2017
@bpasero bpasero removed their assignment Dec 12, 2017
@bpasero bpasero added this to the Backlog Candidates milestone Oct 24, 2019
@vscodebot
Copy link

vscodebot bot commented Jan 22, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot
Copy link

vscodebot bot commented Mar 12, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

@vscodebot
Copy link

vscodebot bot commented Mar 22, 2020

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 22, 2020
@usernamehw
Copy link
Contributor

@bpasero, is it covered in another issue? How is this not a bug?

@usernamehw
Copy link
Contributor

Looks like a duplicate of #14727 which is in the backlog, but it has fewer (5) upvotes...

@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

4 participants