Cursor appears before decoration on empty lines

[nicksnyder]

Extensions like Gitlens register a decoration that appears before each line.

For lines that have content in them, everything works as expected: if you click on the decoration the cursor is placed at the beginning of the line AFTER the decoration.

For lines that do not have any content, the cursor is place BEFORE the decoration. This behavior seems strange.

[eamodio]

@nicksnyder does GitLens always display the annotations chopped like that (where the heatmap is going through the date)?

[nicksnyder]

@eamodio it looks like a bug with gitlens. Filed gitkraken/vscode-gitlens#228

Broken configuration:

"gitlens.blame.file.lineHighlight.locations": [
        "gutter",
        "overviewRuler"
    ],
    "gitlens.annotations.file.gutter.compact": false,
    "gitlens.annotations.file.gutter.format": "[${author|20?}] ${message|20?} ${ago|14-}",

Working configuration

"gitlens.blame.file.lineHighlight.locations": [
        "gutter",
        "overviewRuler"
    ],
    "gitlens.annotations.file.gutter.compact": false,
    "gitlens.annotations.file.gutter.format": "${id} [${author|15?}] ${message|20?} ${ago|14-}",

You should be able to reproduce (the screencap is from mainThreadStorage.ts in vscode).

[nicksnyder]

(even with a working configuration, the issue I reported here still exists)

[eamodio]

@nicksnyder thanks!

[rebornix]

I'm still seeing the cursor showing up before the line decoration when the content is empty

[alexdima]

Here is the extension I've tried with (which works for me):

• package.json:

{
    "publisher": "alex",
    "name": "40127",
    "version": "0.0.0",
    "engines": {
        "vscode": "^1.0.0"
    },
    "activationEvents": [
        "*"
    ],
    "main": "index.js"
}

• index.js:

const vscode = require('vscode');

exports.activate = function () {
	var dectype = vscode.window.createTextEditorDecorationType({
		before: {
			contentText: "1234567890",
			color: "#ff0000"
		}
	});
	vscode.window.activeTextEditor.setDecorations(dectype, [
		new vscode.Range(0, 0, 0, 0),
		new vscode.Range(1, 0, 1, 0),
		new vscode.Range(2, 0, 2, 0),
		new vscode.Range(3, 0, 3, 0),
		new vscode.Range(4, 0, 4, 0),
		new vscode.Range(5, 0, 5, 0),
		new vscode.Range(6, 0, 6, 0),
		new vscode.Range(7, 0, 7, 0),
		new vscode.Range(8, 0, 8, 0),
		new vscode.Range(9, 0, 9, 0),
	]);
}

@eamodio Do these lines get both before and after inline decorations ?

[eamodio]

@alexandrudima yeah, if you have the inline blame turned on, the selected line will also get an after at the end of the line.

[alexdima]

To verify:

• package.json:

{
    "publisher": "alex",
    "name": "40127",
    "version": "0.0.0",
    "engines": {
        "vscode": "^1.0.0"
    },
    "activationEvents": [
        "*"
    ],
    "main": "index.js"
}

• index.js:

const vscode = require('vscode');

exports.activate = function () {
	const dectype1 = vscode.window.createTextEditorDecorationType({
		before: {
			contentText: "1234567890",
			color: "#ff0000"
		}
	});
	vscode.window.activeTextEditor.setDecorations(dectype1, [
		new vscode.Range(0, 0, 0, 0),
		new vscode.Range(1, 0, 1, 0),
		new vscode.Range(2, 0, 2, 0),
		new vscode.Range(3, 0, 3, 0),
		new vscode.Range(4, 0, 4, 0),
		new vscode.Range(5, 0, 5, 0),
		new vscode.Range(6, 0, 6, 0),
		new vscode.Range(7, 0, 7, 0),
		new vscode.Range(8, 0, 8, 0),
		new vscode.Range(9, 0, 9, 0),
	]);
	const dectype2 = vscode.window.createTextEditorDecorationType({
		after: {
			contentText: "abcd",
			color: "#00ff00"
		}
	});
	vscode.window.activeTextEditor.setDecorations(dectype2, [
		new vscode.Range(0, 1000, 0, 1000),
		new vscode.Range(1, 1000, 1, 1000),
		new vscode.Range(2, 1000, 2, 1000),
		new vscode.Range(3, 1000, 3, 1000),
		new vscode.Range(4, 1000, 4, 1000),
		new vscode.Range(5, 1000, 5, 1000),
		new vscode.Range(6, 1000, 6, 1000),
		new vscode.Range(7, 1000, 7, 1000),
		new vscode.Range(8, 1000, 8, 1000),
		new vscode.Range(9, 1000, 9, 1000),
	]);
}

Have an empty line at the beginning of the file. The cursor and the indent guides should render precisely between the before and the after decoration: