Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose refactoring API #41048

Closed
mjbvz opened this issue Jan 2, 2018 · 2 comments · Fixed by #41782
Closed

Propose refactoring API #41048

mjbvz opened this issue Jan 2, 2018 · 2 comments · Fixed by #41782
Assignees
Labels
api plan-item VS Code - planned item for upcoming
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 2, 2018

Explore official API / UX support for refactorings

@mjbvz mjbvz added the plan-item VS Code - planned item for upcoming label Jan 2, 2018
@mjbvz mjbvz added this to the December 2017/January 2018 milestone Jan 2, 2018
@jrieken
Copy link
Member

jrieken commented Jan 3, 2018

@bpasero Do the new async-menus support lazy loading of submenus? So, we could have a 'Refactor' menu and lazily populate it's sub-menu. Is that something we could do now?

@bpasero
Copy link
Member

bpasero commented Jan 4, 2018

@jrieken I am not 100% sure you can modify a menu while it is opened, but we can try. However we are months away from being able to use the async context menu because only recently Electron added the necessary APIs for us to find out when the menu gets closed.

The async options for menus exists already in the Electron version we are using, but we cannot adopt it because we have code that triggers when the menu closes (onHide handler). With the async option there is currently no way to find out when the menu closes so we are stuck with the sync option until we adopted a new major Electron version.

@jrieken jrieken added the api label Jan 16, 2018
@mjbvz mjbvz mentioned this issue Jan 18, 2018
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api plan-item VS Code - planned item for upcoming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants