Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose theme colors to webview via css variables #41785

Closed
eamodio opened this issue Jan 18, 2018 · 2 comments
Closed

Expose theme colors to webview via css variables #41785

eamodio opened this issue Jan 18, 2018 · 2 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality on-testplan webview Webview issues
Milestone
May 2018

Comments

@eamodio
Copy link
Contributor

eamodio commented Jan 18, 2018

  • VSCode Version: Code - Insiders 1.20.0-insider (54240a7, 2018-01-17T05:14:17.405Z)
  • OS Version: Windows_NT x64 10.0.17074

Currently only a couple theme colors are exposed to webviews via css variables, I would like to have access to a full set of theme colors (at least the workbench based ones).
@vscodebot vscodebot bot added the insiders label Jan 18, 2018
@mjbvz mjbvz self-assigned this Jan 18, 2018
@mjbvz mjbvz added the feature-request Request for new features or functionality label Jan 18, 2018
@chrmarti chrmarti removed the insiders label Jan 18, 2018
@mjbvz mjbvz added the webview Webview issues label Jan 19, 2018
@eamodio eamodio mentioned this issue Mar 1, 2018
Open
@benrr101
Copy link

benrr101 commented May 9, 2018

Currently I'm stealingborrowing some code from the gitlens extension, which does a decent job of adding various shades of the colors. It's not a perfect solution, but it's a decent workaround for me.

https://github.com/eamodio/vscode-gitlens/blob/master/src/ui/shared/colors.ts

@mjbvz mjbvz added this to the May 2018 milestone May 14, 2018
@mjbvz mjbvz closed this as completed in 49dec8e May 14, 2018
@eamodio
Copy link
Contributor Author

eamodio commented May 17, 2018

@mjbvz Looks great -- thanks!

@mjbvz mjbvz mentioned this issue May 25, 2018
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality on-testplan webview Webview issues
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
4 participants
@benrr101 @eamodio @chrmarti @mjbvz