Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Windows background updates & update service rewriting #41950

Closed
3 tasks done
joaomoreno opened this issue Jan 22, 2018 · 0 comments
Closed
3 tasks done

Test: Windows background updates & update service rewriting #41950

joaomoreno opened this issue Jan 22, 2018 · 0 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jan 22, 2018

Tests #41676

Complexity: 3

Windows

We now support Windows background updates. The setup package needs a bit of testing:

  • Installing VS Code should be just as before.
  • The setup package should not start installing if there is an instance of Code already running.
  • The 32 bit setup should complain if 64 bit Code is already installed.
  • The update.enableWindowsBackgroundUpdates setting controls whether background updates are enabled. If disabled, update should work as before. If enabled:
    • An update notification should prompt the user to Install Update... instead of Restart Now...
    • There should be a notification window informing the user that the update is being installed in the background.
    • When ready, there should be a badge notification in the gear icon with the Restart Now... action. When clicked, Code should quit, a modal progress window should come up while the update is finalized and then Code should come right back up.
    • If you quit Code before the update is ready, the update should still finish in the background, no progress window should come up and Code shouldn't start up when done.

Windows, Linux, macOS

Additionally, the whole update service was completely rewritten, so a bit of testing on other platforms is also necessary.

Shortly after startup, an automatic check for updates should take place

  • If there is no available update, nothing should happen.
  • Otherwise, a number notification should appear in the gear icon.

Manual update checks behave a bit differently:

  • If there is no available update, a notification should popup up mentioning that there are no available updates.
  • Otherwise, the same should happen: a number notification should appear in the gear icon.

When there is an available update, the experience differs from platform:

  • On Windows, the action should change to a disabled Downloading Update... action, while the update downloads. When ready, there should be a Restart to Update... action which applies the update.
  • On macOS, the action should change to a disabled Downloading Update... action, while the update downloads. When ready, there should be a Restart to Update... action which applies the update.
  • On Linux, there should be a Download Now link, which should open a browser to download the new version. The link should disappear after clicking, in order to check for further updates.
@joaomoreno joaomoreno added this to the January 2018 milestone Jan 22, 2018
@ramya-rao-a ramya-rao-a removed their assignment Jan 31, 2018
@roblourens roblourens removed their assignment Jan 31, 2018
@rebornix rebornix removed their assignment Jan 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants