Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify wording of CodeAction constructor comment #42654

Closed
RMacfarlane opened this issue Jan 31, 2018 · 0 comments
Closed

Clarify wording of CodeAction constructor comment #42654

RMacfarlane opened this issue Jan 31, 2018 · 0 comments
Assignees
@jrieken @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@RMacfarlane
Copy link
Contributor

Testing #42333

Current comment is

A code action must have at least a [title](#CodeAction.title) and either [edits](#CodeAction.edit) or a [command](#CodeAction.command).

which to me sounds like edit and command are mutually exclusive. I think another sentence explaining the behavior when both are present would be helpful.
@mjbvz mjbvz added this to the January 2018 milestone Jan 31, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jan 31, 2018
@mjbvz mjbvz closed this as completed in 64bea8e Jan 31, 2018
@weinand weinand added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@jrieken @weinand @RMacfarlane @mjbvz