Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No quick fix for removing all unused declarations #42659

Closed
ramya-rao-a opened this issue Jan 31, 2018 · 2 comments
Closed

No quick fix for removing all unused declarations #42659

ramya-rao-a opened this issue Jan 31, 2018 · 2 comments
Assignees
@mjbvz
Labels
*as-designed Described behavior is as designed

Comments

@ramya-rao-a
Copy link
Contributor

Testing #42358

In the below case boo, hoo and foo are unused variables.

screen shot 2018-01-31 at 10 56 16 am

I'd expect the quick fix all option to remove all unused declarations in the file instead of removing all unused declarations of foo which is not useful
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 31, 2018

I believe that's what the fix all action already does. It just doesn't have a good name yet, see: microsoft/TypeScript#21380

Can you verify?

@mjbvz mjbvz closed this as completed Feb 2, 2018
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Feb 2, 2018
@ramya-rao-a
Copy link
Contributor Author

I didn't click on it :)

Yes, thats right. It does remove all unused declarations

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjbvz @ramya-rao-a