Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceEdit api - after saving a deleted file, it still shows up as deleted. #42667

Closed
gushuro opened this issue Jan 31, 2018 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workspace-edit
Milestone

Comments

@gushuro
Copy link
Contributor

gushuro commented Jan 31, 2018

Testing #42334

Deleting a file using WorkspaceEdit.deleteResource correctly shows "(deleted from disk)" in the tab title. But if I then edit that tab and save it, it still shows up as deleted, though its a saved file.

Also, if I modify a file with the api after deleting it, the changes still show up on the current tab.

let we = new vscode.WorkspaceEdit();
we.deleteResource(documURI);
we.insert(documURI, position, "InsertText");
vscode.workspace.applyEdit(we);

I'm not quite sure what should happen in this case, but I expected the edits to happen in the same order (first delete, then fail when trying to insert).

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug workspace-edit labels Feb 1, 2018
@jrieken jrieken added this to the February 2018 milestone Feb 1, 2018
@jrieken jrieken modified the milestones: February 2018, March 2018 Feb 27, 2018
@jrieken jrieken removed this from the March 2018 milestone Mar 8, 2018
@jrieken jrieken added this to the June 2018 milestone Jun 19, 2018
@jrieken
Copy link
Member

jrieken commented Jun 19, 2018

fixed by @bpasero changes

@jrieken jrieken closed this as completed Jun 19, 2018
@roblourens roblourens added the verified Verification succeeded label Jun 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workspace-edit
Projects
None yet
Development

No branches or pull requests

3 participants