Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications with buttons should fly out after a timeout #44128

Closed
mattacosta opened this issue Feb 21, 2018 · 2 comments
Closed

Notifications with buttons should fly out after a timeout #44128

mattacosta opened this issue Feb 21, 2018 · 2 comments
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality workbench-notifications Notification widget issues

Comments

@mattacosta
Copy link
Contributor

mattacosta commented Feb 21, 2018

This is a follow-up to #22388.

Summary
Now that notifications appear in the lower-right corner, many users will expect them to well, behave like notifications and go away. Currently, notifications with buttons are permanent, and therefore require user interaction, even in scenarios where it is not required.

Example:

notification_action_required
Figure 1: Attempting to debug a file without a launch configuration.

Here, the alternate workflow is obvious, (manually opening the launch.json file) which means that the notification should go away. This is arguably, also easier, since the explorer and debug panels are very close to each other, while the notification 'x' is on the other side of the screen.

Ideally, all notifications should have a timeout. This would also force developers to fix inappropriate API usage. Practically, notifications with buttons should probably remain in their old top-center position.

@bpasero bpasero changed the title Notifications should not require user interaction Notifications with buttons should fly out after a timeout Feb 21, 2018
@bpasero bpasero added feature-request Request for new features or functionality workbench-notifications Notification widget issues labels Feb 21, 2018
@bpasero
Copy link
Member

bpasero commented Feb 21, 2018

We thought about this but it is unlikely that we can do this easily because our API currently does not distinguish an important message box that the user should act on to a notification that just happens to have buttons.

I think a requirement first would be to have proper API and then we could revisit this.

@bpasero bpasero removed their assignment Feb 22, 2018
@bpasero
Copy link
Member

bpasero commented Sep 11, 2018

Closing "as designed".

@bpasero bpasero closed this as completed Sep 11, 2018
@bpasero bpasero added the *as-designed Described behavior is as designed label Sep 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality workbench-notifications Notification widget issues
Projects
None yet
Development

No branches or pull requests

2 participants