Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Use Electron ASAR to optimize file system access #44455

Closed
3 tasks done
alexdima opened this issue Feb 26, 2018 · 2 comments
Closed
3 tasks done

Test Use Electron ASAR to optimize file system access #44455

alexdima opened this issue Feb 26, 2018 · 2 comments
Labels
testplan-item
Milestone
February 2018

Comments

@alexdima
Copy link
Member

alexdima commented Feb 26, 2018 •
edited by ramya-rao-a
Loading

Test plan item for #36997

Complexity: 3

We have had several issues with using node_modules.asar. Please verify:

  • the installation directory contains node_modules.asar and node_modules.asar.unpacked and no longer node_modules
  • you can use VS Code functionality which involves native node modules or spawning processes with files included in node modules: e.g. winpty for terminal, rg for searching.
@alexdima alexdima added this to the February 2018 milestone Feb 26, 2018
@jrieken jrieken removed their assignment Feb 27, 2018
@Tyriar Tyriar removed their assignment Feb 27, 2018
@Tyriar Tyriar closed this as completed Feb 27, 2018
@alexdima alexdima reopened this Feb 27, 2018
@alexdima
Copy link
Member Author

@Tyriar I think we should close only once @ramya-rao-a also tests.

@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2018

Opps 😅

@ramya-rao-a ramya-rao-a removed their assignment Feb 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
4 participants
@jrieken @Tyriar @alexdima @ramya-rao-a