Cannot set function breakpoint

[chrmarti]

Issue Type: Bug

Testing #43836

Following the documentation on this, the function breakpoint did not work. Also note that in the screenshot the function breakpoint is shown as resolved, but when I add it while the program is running, it is shown as unresolved.

VS Code version: Code - Insiders 1.21.0-insider (1a84a88, 2018-02-27T06:09:52.377Z)
OS version: Darwin x64 16.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.25GB free)
Process Argv	/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron --user-data-dir tmp/user --extensions-dir tmp/ext
Screen Reader	no
VM	20%

Extensions: none Reproduces without extensions

[isidorn]

@weinand can you please investigate if the backend is providing the expected data.

[weinand]

What node.js version are you using?

Please be aware of the limitations of function breakpoints: https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_function-breakpoints
You must use the "legacy" protocol which requires node.js < 8.0. If you are using "nvm" you can add a "runtimeVersion" attribute to your launch config.

[chrmarti]

Retried with v6.11.3 and it didn't work. (This time the function breakpoint was shown as unconfirmed when I started debugging.)

[joaomoreno]

This also didn't work for me in extension development.

[weinand]

node.js versions >= 8.0 no longer support function breakpoints.

[isidorn]

@weinand should the adapter then return function breakpoints as unverified. Or it already does that but the UI is not respecting it?

[weinand]

for node.js >= 8 the adapter does not support function breakpoints so "supportsFunctionBreakpoints" is falsy. VS Code should not call functionBreakpoints and there is no response.

for node.js < 8 the DA sends back Breakpoint with the "verified" property set to true, see:
https://github.com/Microsoft/vscode-node-debug/blob/602790fc530a89825bcc779b2f4cfbb249c8a199/src/node/nodeDebug.ts#L2121-L2127

[isidorn]

In the latest we properly show that the breakpoint is not resolved no matter when it is added. So imho this behaves fine now