Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Extension notification does nothing #44511

Closed
dbaeumer opened this issue Feb 27, 2018 · 6 comments
Closed

Manage Extension notification does nothing #44511

dbaeumer opened this issue Feb 27, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #44319

Clicking on the gear icon and selecting Manage Extension did nothing for me.

capture

@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

@dbaeumer you probably ran an extension out of sources via debugger? In that case the action is a no-op, it will only work with installed extensions.

To test this you could try to trigger an error from GIT, e.g. try to commit a file with formatting errors.

@bpasero bpasero added the info-needed Issue requires more information from poster label Feb 27, 2018
@dbaeumer
Copy link
Member Author

Yes, I ran it from source. Should we then remove the action ?

@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

@sandy081 actually maybe this is a bug, should it be possible to open the extension editor for an extension that is just debugged at the same time? This could be helpful to debug how an extension looks like based on the package.json contents.

@bpasero bpasero added this to the February 2018 milestone Feb 27, 2018
@bpasero bpasero added workbench-notifications Notification widget issues and removed info-needed Issue requires more information from poster labels Feb 27, 2018
@sandy081
Copy link
Member

It is possible but not trivial as extensions workbench/management is not aware of such a thing called developing extension.

@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

@sandy081 is there a way to find out if the extension is running "out of sources"? then I could maybe not add the action.

@sandy081
Copy link
Member

sandy081 commented Feb 27, 2018

There is no direct API.

But can get that information by using getExtensions to get the IExtensionDescription and check if IExtensionDescription.extensionFolderPath is same as extensionDevelopmentPath

@bpasero bpasero changed the title Manage Extension notofication does nothing Manage Extension notification does nothing Feb 27, 2018
@bpasero bpasero modified the milestones: February 2018, March 2018 Feb 27, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 27, 2018
@mjbvz mjbvz added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Development

No branches or pull requests

4 participants