Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification UI: Gear and close button not keyboard accessible #44541

Closed
dbaeumer opened this issue Feb 27, 2018 · 6 comments
Closed

Notification UI: Gear and close button not keyboard accessible #44541

dbaeumer opened this issue Feb 27, 2018 · 6 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug list-widget List widget issues verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #44319

I was not able to navigate to the two buttons using the keyboard on Windows.

@dbaeumer dbaeumer added the workbench-notifications Notification widget issues label Feb 27, 2018
@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

Steps: select a collapsed message and hit Tab, it does not move into actions probably because the actions hide when tabbing.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Feb 27, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 27, 2018
@bpasero bpasero assigned joaomoreno and unassigned bpasero Feb 27, 2018
@bpasero bpasero added list-widget List widget issues and removed workbench-notifications Notification widget issues labels Feb 27, 2018
@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

@joaomoreno looks like a regression in the list to me, reproduces in the extensions list as well:

before

Steps:

  • select an item
  • hit tab
  • the action is no longer selected that is part of the item, instead the first one is navigated to

@joaomoreno
Copy link
Member

joaomoreno commented Feb 28, 2018

@bpasero I believe you implemented this back in the days by hijackign what Tab would do when there is a focused element, am I right?

@bpasero
Copy link
Member

bpasero commented Feb 28, 2018

@joaomoreno sorry I do not recall that anymore. I would find it dangerous to overwrite what Tab key does because maybe there are other keys to trigger this?

@joaomoreno
Copy link
Member

Turns out it never worked!

@bpasero
Copy link
Member

bpasero commented Feb 28, 2018

Thanks dude!

@bpasero bpasero added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug list-widget List widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants