Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit function breakpoints after first edit #44556

Closed
joaomoreno opened this issue Feb 27, 2018 · 3 comments
Closed

Can't edit function breakpoints after first edit #44556

joaomoreno opened this issue Feb 27, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #43836

Shouldn't double click allow me to edit the breakpoint?

@isidorn isidorn added this to the February 2018 milestone Feb 27, 2018
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 27, 2018
@isidorn isidorn closed this as completed in 9ba6d40 Mar 1, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2018

Pushed some function breakpoint polish. Now you can double click to edit and there is also a context menu "edit breakpoint" item.
There are still some rough edges since the issue is taht I am reusing the inputBox template and the listeners have some timing issues. But will only fix those if users complain since it requires a bigger refactoring (function breakpoints are not that popular)

@bpasero bpasero added the verified Verification succeeded label Mar 2, 2018
@bpasero
Copy link
Member

bpasero commented Mar 2, 2018

I would probably expect the input to close when focus moves out, same as how the explorer rename works.

Also, when I double click, focus is not put into the input box. Is that already reported?

@isidorn
Copy link
Contributor

isidorn commented Mar 2, 2018

That is not reported, just created an issue to track that
#44912

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants