Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications center background is blue in high contrast theme #44596

Closed
Tyriar opened this issue Feb 27, 2018 · 1 comment
Closed

Notifications center background is blue in high contrast theme #44596

Tyriar opened this issue Feb 27, 2018 · 1 comment
Assignees
@bpasero
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *as-designed Described behavior is as designed workbench-notifications Notification widget issues
Milestone
February 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2018

VS Code version: Code - Insiders 1.21.0-insider (1a84a88, 2018-02-27T06:17:53.785Z)
OS version: Linux x64 4.13.0-36-generic

#44319

image

I don't think this background is used elsewhere?
@Tyriar Tyriar added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues workbench-notifications Notification widget issues labels Feb 27, 2018
@vscodebot vscodebot bot added the insiders label Feb 27, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 27, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2018
@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

@Tyriar we do, it is the editor widget background color that is e.g. also used for find widget:

image

The idea is to pick a background color that has some contrast to the editor because that is typically where notifications will appear on top of.

@bpasero bpasero closed this as completed Feb 27, 2018
@bpasero bpasero added *as-designed Described behavior is as designed and removed bug Issue identified by VS Code Team member as probable bug labels Feb 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *as-designed Described behavior is as designed workbench-notifications Notification widget issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
2 participants
@bpasero @Tyriar